]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
overviewControls: don't override explicit calls to slideIn
authorCarlos Soriano <carlos.soriano89@gmail.com>
Sat, 26 Jul 2014 15:36:17 +0000 (17:36 +0200)
committerCarlos Soriano <carlos.soriano89@gmail.com>
Fri, 8 Aug 2014 14:40:41 +0000 (16:40 +0200)
Currently we are overriding the explicit calls to slideIn
given that it's called also with the signal of showing overview.

It was necessary because of the bug that previous patch fixed,
so now we can just delete that.

https://bugzilla.gnome.org/show_bug.cgi?id=732901

js/ui/overviewControls.js

index b396ff012d7c2c98096b08abea1be823eb374b43..261c1034ab649eb3adebafb661792b9270c5ef33 100644 (file)
@@ -118,7 +118,6 @@ const SlidingControl = new Lang.Class({
                                      style_class: 'overview-controls',
                                      clip_to_allocation: true });
 
-        Main.overview.connect('showing', Lang.bind(this, this._onOverviewShowing));
         Main.overview.connect('hiding', Lang.bind(this, this._onOverviewHiding));
 
         Main.overview.connect('item-drag-begin', Lang.bind(this, this._onDragBegin));
@@ -177,14 +176,9 @@ const SlidingControl = new Lang.Class({
                                         transition: 'easeOutQuad' });
     },
 
-    _onOverviewShowing: function() {
-        this._visible = true;
-        this.layout.slideX = this._getSlide();
-        this.layout.translationX = this._getTranslation();
-        this.slideIn();
-    },
-
     _onOverviewHiding: function() {
+        // We need to explicitily slideOut since showing pages
+        // doesn't implies to slide out, instead, hiding the overview does.
         this.slideOut();
     },